Round Times: Set minimum dynamic filter timeout to 2500ms. #5853
Merged
jannotti merged 1 commit intoalgorand:masterfrom Dec 7, 2023
Merged
Round Times: Set minimum dynamic filter timeout to 2500ms. #5853jannotti merged 1 commit intoalgorand:masterfrom
jannotti merged 1 commit intoalgorand:masterfrom
Conversation
…round lag to 8 (helping stabilize for voteValidatedAt lookups in telemetry).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5853 +/- ##
==========================================
+ Coverage 55.86% 55.89% +0.02%
==========================================
Files 477 477
Lines 67259 67262 +3
==========================================
+ Hits 37576 37595 +19
+ Misses 27133 27122 -11
+ Partials 2550 2545 -5 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Dec 4, 2023
jannotti
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set minimum dynamic filter timeout to 2500ms. Additionally, set minimum credential round lag to 8 (helping stabilize for voteValidatedAt lookups in telemetry).
Test Plan
Existing tests pass.