Round Times: Period 0 deadline timeout#5850
Merged
gmalouf merged 5 commits intoalgorand:masterfrom Dec 7, 2023
Merged
Conversation
…o better reflect the variable's purpose. Fix deadline timeout references that either needed to provide period now or needed the default deadline timeout.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5850 +/- ##
==========================================
+ Coverage 55.88% 55.92% +0.04%
==========================================
Files 477 477
Lines 67259 67272 +13
==========================================
+ Hits 37586 37622 +36
+ Misses 27127 27109 -18
+ Partials 2546 2541 -5 ☔ View full report in Codecov by Sentry. |
jannotti
reviewed
Dec 1, 2023
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
I'm not sure any real harm will come from my concern.
algorandskiy
reviewed
Dec 1, 2023
Co-authored-by: John Jannotti <jannotti@gmail.com>
…te to for a possible version zero value.
cce
reviewed
Dec 5, 2023
cce
reviewed
Dec 5, 2023
zeldovich
reviewed
Dec 5, 2023
…er.go, applying the resolved timeout to both issueSoftVote and nextVoteRanges.
algorandskiy
approved these changes
Dec 7, 2023
jannotti
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a consensus parameter
AgreementDeadlineTimeoutPeriod0, that as the name implies is used for setting a common period 0 deadline timeout. References to the deadline timeout in the codebase have been updated to reflect whether they need the existing default or to resolve a timeout based on a current period of consensus (and the active consensus version).Test Plan
Existing tests should all pass (several pass in period 0 or period 1 in agreement/service_test.go).