tests: wait longer in TestTotalWeightChanges for larger nightly test network#5841
Merged
jannotti merged 1 commit intoalgorand:masterfrom Dec 7, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5841 +/- ##
==========================================
- Coverage 55.81% 55.77% -0.05%
==========================================
Files 476 476
Lines 67138 67138
==========================================
- Hits 37476 37448 -28
- Misses 27141 27154 +13
- Partials 2521 2536 +15 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Nov 21, 2023
jannotti
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During nightly / non-short runs,
TestTotalWeightChangesuses a 7-node test network (compared to 3 nodes for PR commit short tests) and sometimes hits this 30s timeout when running in CI, this happens while nodes are first starting up and not yet finished coming to agreement on round 1. Provides a little more time for nodes to start up in a resource constrained nightly CI runner machineTest Plan
Tests are unchanged except for length of timeout.