catchup: use specialized backoff behavior for follower mode#5836
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Nov 16, 2023
Merged
catchup: use specialized backoff behavior for follower mode#5836algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5836 +/- ##
==========================================
- Coverage 55.77% 55.13% -0.65%
==========================================
Files 476 476
Lines 67166 67170 +4
==========================================
- Hits 37463 37032 -431
- Misses 27172 27575 +403
- Partials 2531 2563 +32 ☔ View full report in Codecov by Sentry. |
jasonpaulos
approved these changes
Nov 16, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good and SDK tests are passing with the same sleep time of 1s as before: https://app.circleci.com/pipelines/github/algorand/js-algorand-sdk/1284/workflows/bd4df97f-2ee0-4589-bf4e-fdc99e816bc1
winder
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This introduces polling delay between 404 responses for blocks when running in follow mode, which uses catchup to continuously poll for new blocks, rather than using agreement. In follow mode, aborting the catchup process causes unnecessary latency in observing the latest blocks.
On the contrary, in regular catchup, it is desirable to abort catchup right away when you reach the latest round, so that agreement can take over.
Test Plan
Existing tests should pass — @algorandskiy found in #5809 that many tests depend on the desired no-backoff-and-quit-fast behavior in regular catchup.