config: add EnableGossipService option#5832
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Nov 17, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5832 +/- ##
==========================================
+ Coverage 55.81% 55.85% +0.03%
==========================================
Files 476 476
Lines 67138 67142 +4
==========================================
+ Hits 37476 37503 +27
+ Misses 27141 27119 -22
+ Partials 2521 2520 -1 ☔ View full report in Codecov by Sentry. |
ohill
force-pushed
the
config-gossip-service
branch
from
bd8c31a to
555c4c8
Compare
algorandskiy
previously approved these changes
Nov 15, 2023
algorandskiy
approved these changes
Nov 15, 2023
cce
reviewed
Nov 17, 2023
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a configuration option
EnableGossipService, true by default, for whether to serve the/v1/{genesisID}/gossipHTTP endpoint on the port configured in NetAddress. This could be useful for algod nodes that want to only serve the blocks HTTP endpoint (EnableBlockService) and/or the catchpoint file HTTP endpoint (EnableLedgerService) on the NetAddress port.Test Plan
Added new test "TestWebsocketNetworkNoGossipService"