algocfg: Add print option to algocfg.#5824
Merged
winder merged 7 commits intoalgorand:masterfrom Nov 13, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5824 +/- ##
==========================================
+ Coverage 55.61% 55.71% +0.09%
==========================================
Files 475 475
Lines 66909 66916 +7
==========================================
+ Hits 37212 37280 +68
+ Misses 27182 27109 -73
- Partials 2515 2527 +12
... and 11 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
jasonpaulos
previously approved these changes
Nov 9, 2023
Contributor
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good and makes sense. I left a comment about a nit, but I don't consider that a blocker. If that error comes up in the future it can always be addressed then.
jasonpaulos
previously approved these changes
Nov 9, 2023
winder
commented
Nov 9, 2023
winder
commented
Nov 9, 2023
gmalouf
reviewed
Nov 9, 2023
gmalouf
requested changes
Nov 9, 2023
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
I think anything we are adding that is reusable across go-algorand should get basic testing, so in this case json.go could use a smoke test.
gmalouf
reviewed
Nov 13, 2023
gmalouf
approved these changes
Nov 13, 2023
jasonpaulos
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I frequently want to tell people a default configuration according to algocfg, but the only way to use it involves updating/creating a file in the data directory.
This PR adds a new
algocfg profile print <profile>subcommand that writes configuration to stdout instead of to a regular file.Test Plan
Manual testing: