build: regenerate api routes and resolve merge error in catchup#5821
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Nov 8, 2023
Merged
build: regenerate api routes and resolve merge error in catchup#5821algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy merged 2 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5821 +/- ##
=======================================
Coverage 55.60% 55.60%
=======================================
Files 475 475
Lines 66921 66946 +25
=======================================
+ Hits 37209 37228 +19
- Misses 27187 27198 +11
+ Partials 2525 2520 -5
... and 14 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
winder
previously approved these changes
Nov 8, 2023
algorandskiy
force-pushed
the
pavel/codegen-build-fix
branch
from
1472bd6 to
9871314
Compare
winder
reviewed
Nov 8, 2023
winder
approved these changes
Nov 8, 2023
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
All of these changes look fine. One of them doesn't match the current description/title.
algorandskiy
changed the title
gmalouf
approved these changes
Nov 8, 2023
jannotti
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Somehow the latest merge caused codegen checker error, this regenerates stuff.
Regenerated with
Also there are two conflicting catchup PRs were merged causing error usage that was changed. Fixed as well.