catchup: alternative pause catchup if ledger lagging behind#5803
Closed
algorandskiy wants to merge 11 commits intoalgorand:masterfrom
Closed
catchup: alternative pause catchup if ledger lagging behind#5803algorandskiy wants to merge 11 commits intoalgorand:masterfrom
algorandskiy wants to merge 11 commits intoalgorand:masterfrom
Conversation
Co-authored-by: John Jannotti <jannotti@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5803 +/- ##
==========================================
+ Coverage 55.55% 55.58% +0.03%
==========================================
Files 474 474
Lines 66850 66878 +28
==========================================
+ Hits 37138 37174 +36
+ Misses 27188 27183 -5
+ Partials 2524 2521 -3
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
ported to #5794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is alternative to the #5794
The main difference is the last commit where
pipelinedFetchis suspended to let pending goroutines to complete and write blocks rather than about and cancel. This should help with bandwidth usage.