tools: improve heapwatch chart drawing scripts#5801
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Oct 25, 2023
Merged
tools: improve heapwatch chart drawing scripts#5801algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy merged 2 commits intoalgorand:masterfrom
Conversation
* plot_crr_csv: use round numbers for x axis scaling * metrics_viz: allow drawing difference of two metrics Additionally fixed e2e logger to report actual invocation file:line and not fixture.go:171 from syncTest implementation wrapper
Codecov Report
@@ Coverage Diff @@
## master #5801 +/- ##
==========================================
+ Coverage 55.57% 55.60% +0.02%
==========================================
Files 475 475
Lines 66838 66838
==========================================
+ Hits 37147 37163 +16
+ Misses 27172 27158 -14
+ Partials 2519 2517 -2 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gmalouf
reviewed
Oct 24, 2023
gmalouf
previously approved these changes
Oct 24, 2023
gmalouf
approved these changes
Oct 25, 2023
cce
approved these changes
Oct 25, 2023
jasonpaulos
approved these changes
Oct 25, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good, just a question
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additionally fixed e2e logger to report actual invocation file:line and not fixture.go:171 from syncTest implementation wrapper
Test Plan
This is test/tools fix, tested manually. Rendered charts in this PR #5794 description.