catchpoint: store certs with blocks during catchpoint restore#5798
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Oct 24, 2023
Merged
catchpoint: store certs with blocks during catchpoint restore#5798algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
algorandskiy
previously approved these changes
Oct 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #5798 +/- ##
==========================================
+ Coverage 54.45% 55.54% +1.09%
==========================================
Files 475 475
Lines 66848 66852 +4
==========================================
+ Hits 36399 37131 +732
+ Misses 27903 27199 -704
+ Partials 2546 2522 -24
... and 81 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Oct 23, 2023
winder
approved these changes
Oct 24, 2023
Contributor
winder
left a comment
There was a problem hiding this comment.
Works as advertised:
mkdir localtest && cd localtest
cp /path/to/betanet/genesis.json .
algocfg profile set conduit -d .
goal node start -d .
goal node catchup -d .
# catchpoint 30660000 is used
# block in json format
curl -H "Authorization: Bearer <token>" "localhost:8080/v2/blocks/30660000?format=json"
<expected output>
# block in msgpack format
curl -H "Authorization: Bearer <token>" "localhost:8080/v2/blocks/30660000?format=msgpack"
<expected output>
# delta output
curl -H "Authorization: Bearer <token>" "localhost:8080/v2/deltas/30660000"
<expected output>
Please remember to change this from >= to > after the next consensus upgrade:
https://github.com/algorand/conduit/blob/3357b4078db592f3c2d9ddfb341f98d92b5fed40/conduit/plugins/importers/algod/algod_importer.go#L189
This was referenced Nov 16, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each block certificate is downloaded but thrown away during catchpoint restore, leading to errors like #5352 when trying to retrieve blocks with their certificates later. Since we always store blocks and certs together this keeps the certificates from being thrown away so
certdataends up in the block db with theblkdataCloses #5352.
Test Plan
Updated TestBasicCatchpointCatchup to request a msgpack block at the end.