follower: update follower node error messages.#5797
Merged
winder merged 1 commit intoalgorand:masterfrom Oct 23, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5797 +/- ##
==========================================
+ Coverage 55.32% 55.56% +0.23%
==========================================
Files 475 475
Lines 66850 66850
==========================================
+ Hits 36988 37142 +154
+ Misses 27341 27187 -154
Partials 2521 2521
... and 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Oct 23, 2023
jasonpaulos
approved these changes
Oct 23, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
I think the added benefit of clarity here outweigh the potential risks
ohill
approved these changes
Oct 23, 2023
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The feature was renamed from
synctofollowerand this error message was not updated along with it.There is a possibility that user code could be checking for this message, so this could be considered a breaking change. This error message also indicates a configuration issue, so error handling would be unable to resolve it.
My recommendation is to make the breaking change.
Test Plan