avm: preserve line/column for assembler warnings#5796
Merged
jannotti merged 2 commits intoalgorand:masterfrom Oct 24, 2023
Merged
avm: preserve line/column for assembler warnings#5796jannotti merged 2 commits intoalgorand:masterfrom
jannotti merged 2 commits intoalgorand:masterfrom
Conversation
dragmz
changed the title
algorandskiy
changed the title
Contributor
|
Looks good, we just have to figure out how to get the CircleCI tests to all run. We need to make sure there aren't tests, especially in the end-to-end tests, that depend on the old format. |
Contributor
|
Closed/re-opened to workaround CircleCI error |
jasonpaulos
reviewed
Oct 23, 2023
jasonpaulos
approved these changes
Oct 23, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Pending tests passing, LGTM
Contributor
|
Looks like it is trying to authenticate a user who triggered a build event, and if it does not have CircleCI linked account, it fails. OK. |
Codecov Report
@@ Coverage Diff @@
## master #5796 +/- ##
==========================================
+ Coverage 55.32% 55.59% +0.26%
==========================================
Files 475 475
Lines 66850 66850
==========================================
+ Hits 36988 37162 +174
+ Misses 27341 27175 -166
+ Partials 2521 2513 -8
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Oct 23, 2023
jannotti
approved these changes
Oct 24, 2023
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified OpStream Warnings from []error to []sourceError to preserve line and column information so it can be used by TEAL language servers to display a location of warnings.
Test Plan
Added unit tests for warnings with zero and non-zero lines/columns