CICD: Fix RPM repository updating#5790
Merged
onetechnical merged 4 commits intoalgorand:masterfrom Oct 19, 2023
Merged
Conversation
- Use STAGING env var - Fix AWS sync for signatures - If S3_SOURCE missing detect the channel for package naming - Remove custom GnuPG binary - we can use default on CentOS 8
Codecov Report
@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
+ Coverage 55.55% 55.57% +0.01%
==========================================
Files 475 475
Lines 66850 66850
==========================================
+ Hits 37140 37151 +11
+ Misses 27191 27186 -5
+ Partials 2519 2513 -6 see 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Oct 19, 2023
gmalouf
approved these changes
Oct 19, 2023
onetechnical
added a commit
to Algo-devops-service/go-algorand
that referenced
this pull request
Oct 20, 2023
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was broken because of adding an S3 sync of signatures, but there were other issues uncovered.
Note that the beta channel RPM repository has been non-functional to date, due to lack of a repo definition file, which was fixed as part of this testing.
The purpose of this was to narrowly fix the repository issue, However a closer look at simplifying this process is recommended in the future.
Test Plan
Re-ran the update for the beta release. Verified signatures validated with RPM key.
These changes should be cherry-picked into the next stable release as well.