AVM: Reorganize the crypto opcodes a bit to simplify incentive work#5787
Merged
jannotti merged 3 commits intoalgorand:masterfrom Oct 18, 2023
Merged
AVM: Reorganize the crypto opcodes a bit to simplify incentive work#5787jannotti merged 3 commits intoalgorand:masterfrom
jannotti merged 3 commits intoalgorand:masterfrom
Conversation
jannotti
force-pushed
the
crypto-reorg
branch
from
0f65051 to
82e9b6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #5787 +/- ##
==========================================
+ Coverage 55.55% 55.58% +0.03%
==========================================
Files 474 475 +1
Lines 66850 66850
==========================================
+ Hits 37138 37161 +23
+ Misses 27188 27180 -8
+ Partials 2524 2509 -15
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
changed the title
jasonpaulos
reviewed
Oct 18, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks mostly good, I just have some minor questions/comments.
I also verified the new crypto.go contains exactly the code removed from eval.go
jasonpaulos
approved these changes
Oct 18, 2023
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
LGTM, one question about a newly added notrack below
algorandskiy
approved these changes
Oct 18, 2023
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves type checking a bit, improves ease of unit tests for new opcodes, moves crypto into their own files, adds some coverage.