catchpoints: check EnableCatchupFromArchiveServers for ledgerFetcher

[ohill]

Summary

The ledgerFetcher is used by the catchpointService to download the catchpoint file (ledger snapshot) and uses a peerSelector that only connects to relays. This change updates it to use the same makePeerSelector arguments as used when downloading blocks as part of fast catchup, where EnableCatchupFromArchiveServers is checked.

Fixes #5765.

Test Plan

Existing tests should pass.

[codecov]

Codecov Report

Merging #5783 (ebbe007) into master (0358d1d) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #5783   +/-   ##
=======================================
  Coverage   55.46%   55.47%           
=======================================
  Files         473      473           
  Lines       66720    66722    +2     
=======================================
+ Hits        37005    37012    +7     
+ Misses      27197    27189    -8     
- Partials     2518     2521    +3     

Files	Coverage Δ
catchup/catchpointService.go	8.44% <50.00%> (+0.40%)	⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[winder]

This doesn't look like it would hurt anything, but I don't know the catchpoint download retry logic well enough to tell if it would solve #5765.

Additional context: #5393

[ohill]

This doesn't look like it would hurt anything, but I don't know the catchpoint download retry logic well enough to tell if it would solve #5765.

Additional context: #5393

There are two peerSelectors updated in this PR. The first one is created in processStageLedgerDownload to download the catchpoint file. The second one is created in checkLedgerDownload which was added in #5393. Now they both use the same peerSelector as used to download blocks during fast catchup