API: Add participation key generation endpoint to algod API#5781
Merged
winder merged 20 commits intoalgorand:masterfrom Oct 17, 2023
Merged
API: Add participation key generation endpoint to algod API#5781winder merged 20 commits intoalgorand:masterfrom
winder merged 20 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5781 +/- ##
=======================================
Coverage 55.53% 55.53%
=======================================
Files 473 474 +1
Lines 66815 66851 +36
=======================================
+ Hits 37105 37127 +22
- Misses 27192 27199 +7
- Partials 2518 2525 +7
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
commented
Oct 13, 2023
winder
commented
Oct 13, 2023
jannotti
reviewed
Oct 13, 2023
Contributor
jannotti
left a comment
There was a problem hiding this comment.
I had some comments that I forgot to submit. I think I still have more to look at and understand though.
jasonpaulos
reviewed
Oct 13, 2023
jasonpaulos
reviewed
Oct 16, 2023
jasonpaulos
approved these changes
Oct 17, 2023
jannotti
approved these changes
Oct 17, 2023
Contributor
jannotti
left a comment
There was a problem hiding this comment.
I left some very small nits, but approving. If you want to change them, I'll reapprove immediately. Up to you.
This was referenced Oct 17, 2023
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation for #5578.
New endpoint for the admin API to generate and install participation keys.
The participation keys are generated in the background and installed when generation is complete. With this PR there is no progress reporting. Programs should poll the
GET /v2/participationendpoint and look for the new key to appear. Once the new key is installed a key registration transaction can be made.Test Plan
New unit tests.