Skip to content

tests: Remove flaky persistent peers test from wsNetwork #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmalouf merged 1 commit into from
Oct 3, 2023
Merged

tests: Remove flaky persistent peers test from wsNetwork #5772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions network/wsNetwork_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4260,39 +4260,6 @@ func TestUpdatePhonebookAddresses(t *testing.T) {
})
}

func TestUpdatePhonebookAddressesPersistentPeers(t *testing.T) {
partitiontest.PartitionTest(t)

rapid.Check(t, func(t1 *rapid.T) {
nw := makeTestWebsocketNode(t)
// Generate a new set of relay domains
// Dont overlap with archive nodes previously specified, duplicates between them not stored in phonebook as of this writing
relayDomainsGen := rapid.SliceOfN(rapidgen.DomainOf(253, 63, "", nil), 0, 200)
relayDomains := relayDomainsGen.Draw(t1, "relayDomains")

var persistentPeers []string
// Add an initial set of relay domains as Persistent Peers in the Phonebook,
persistentPeers = rapid.SliceOfN(rapidgen.DomainOf(253, 63, "", relayDomains), 0, 200).Draw(t1, "")
nw.phonebook.AddPersistentPeers(persistentPeers, string(nw.NetworkID), PhoneBookEntryRelayRole)

// run updatePhonebookAddresses
nw.updatePhonebookAddresses(relayDomains, nil)

// Check that entries are in fact in phonebook less any duplicates
dedupedRelayDomains := removeDuplicateStr(relayDomains, false)

relayPeers := nw.GetPeers(PeersPhonebookRelays)
require.Equal(t, len(dedupedRelayDomains)+len(persistentPeers), len(relayPeers))

relayAddrs := make([]string, 0, len(relayPeers))
for _, peer := range relayPeers {
relayAddrs = append(relayAddrs, peer.(HTTPPeer).GetAddress())
}

require.ElementsMatch(t, append(dedupedRelayDomains, persistentPeers...), relayAddrs)
})
}

func removeDuplicateStr(strSlice []string, lowerCase bool) []string {
allKeys := make(map[string]bool)
var dedupStrSlice = make([]string, 0)
Expand Down