docker: Do not disable telemetry if logging.config is present.#5769
Merged
winder merged 1 commit intoalgorand:masterfrom Oct 4, 2023
Merged
docker: Do not disable telemetry if logging.config is present.#5769winder merged 1 commit intoalgorand:masterfrom
winder merged 1 commit intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5769 +/- ##
==========================================
- Coverage 55.50% 55.44% -0.06%
==========================================
Files 473 473
Lines 66684 66684
==========================================
- Hits 37010 36975 -35
- Misses 27156 27187 +31
- Partials 2518 2522 +4 see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ohill
approved these changes
Oct 3, 2023
gmalouf
approved these changes
Oct 4, 2023
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
I think your suggestion is the right approach - we may need to communicate this a bit though hard to tell to whom..
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docker image proactively disables telemetry if
TELEMETRY_NAMEis not set. Presumably this was to allow turning telemetry on and off for an existing container. This has a side effect of disabling telemetry enabled by alogging.configoverride.We have two options:
logging.config. No change is necessary.logging.configis provided and noTELEMETRY_NAMEis provided, skip disabling telemetry.Test Plan
Manually tested the bash script and ran it through shellcheck.