tests: Fix flaky tealdbg unit test#5768
Merged
gmalouf merged 1 commit intoalgorand:masterfrom Oct 4, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5768 +/- ##
==========================================
- Coverage 55.50% 55.45% -0.05%
==========================================
Files 473 473
Lines 66684 66684
==========================================
- Hits 37010 36977 -33
- Misses 27156 27188 +32
- Partials 2518 2519 +1 see 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gmalouf
approved these changes
Oct 3, 2023
winder
approved these changes
Oct 4, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our arm64 nightly build shows a test failure of
TestServerLocaland several others from the packagecmd/tealdbg: https://app.circleci.com/pipelines/github/algorand/go-algorand/16882/workflows/78daf42e-bd47-4f33-8ac2-b210eaf0b2bb/jobs/256093/testsI can't say why the others failed (in fact I'm suspicious this is a reporting error), but the failure from
TestServerLocalindicates that it couldn't find a free port to use for its server. I've fixed this by using port 0, which should assign it any randomly-chosen available port.Test Plan
Test-only fix