ci: fix scripts/create_and_deploy_recipe.sh build#5764
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Sep 29, 2023
Merged
ci: fix scripts/create_and_deploy_recipe.sh build#5764algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
onetechnical
previously approved these changes
Sep 28, 2023
Contributor
onetechnical
left a comment
There was a problem hiding this comment.
Seems okay, though I would often use build-essential instead of make & g++.
winder
previously approved these changes
Sep 28, 2023
Contributor
winder
left a comment
There was a problem hiding this comment.
lgtm. I just changed the title tag to "ci" instead of "docker".
Contributor
Author
|
Looks like there is another issue with hidden |
812a767
ced2339 to
812a767
Compare
winder
approved these changes
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #5764 +/- ##
==========================================
+ Coverage 55.46% 55.48% +0.02%
==========================================
Files 473 473
Lines 66682 66682
==========================================
+ Hits 36986 37001 +15
+ Misses 27178 27168 -10
+ Partials 2518 2513 -5 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
approved these changes
Sep 29, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix binaries build for local cluster deployment with docker.
Some errors seen are:
Additionally, fix
._Wallethidden files in tar archive withexport COPYFILE_DISABLE=trueas per this postOtherwise algod is trying to load these metadata files and fails with
{"file":"main.go","function":"main.run","level":"error","line":326,"msg":"couldn't initialize the node: AlgorandFullNode.loadParticipationKeys: cannot load db ._Wallet2.0.30000.partkey: file is not a database","time":"2023-09-28T19:40:02.936041Z"}when starting with a dir containing
Test Plan
Local build with
./scripts/create_and_deploy_recipe.sh -c $NETWORK_NAME --recipe test/testdata/deployednettemplates/recipes/custom/recipe.json -r ~/networks/$NETWORK_NAME -b $S3_RELEASE_BUCKETsucceeded.