tools: better heap data rendering#5761
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Sep 27, 2023
Merged
Conversation
jasonpaulos
approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #5761 +/- ##
==========================================
+ Coverage 54.59% 55.47% +0.88%
==========================================
Files 473 473
Lines 66682 66682
==========================================
+ Hits 36403 36991 +588
+ Misses 27751 27180 -571
+ Partials 2528 2511 -17 see 49 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heapWatch's metric renderer does not work well for multiple nodes. This slightly improves heap chart rendering.
Also fixed IP to nicknames resolution.
Not super great but better.
Test Plan