Merged
Conversation
|
|
algorandskiy
previously approved these changes
Sep 28, 2023
Contributor
|
This is the same as #5719 |
winder
reviewed
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #5759 +/- ##
==========================================
+ Coverage 55.61% 55.64% +0.03%
==========================================
Files 475 476 +1
Lines 66946 67003 +57
==========================================
+ Hits 37230 37284 +54
- Misses 27194 27203 +9
+ Partials 2522 2516 -6
... and 15 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
algorandskiy
previously approved these changes
Sep 29, 2023
ohill
reviewed
Oct 3, 2023
ohill
reviewed
Oct 3, 2023
ohill
reviewed
Oct 3, 2023
ohill
reviewed
Oct 3, 2023
ohill
reviewed
Oct 4, 2023
ohill
reviewed
Oct 4, 2023
Contributor
Author
|
@ohill thank you for reviewing nibbles! |
Contributor
|
@bbroder-uji Looks like you need to run go fmt or |
bbroder-uji
force-pushed
the
nibbles_2
branch
from
086f8cb to
1a0fd52
Compare
Contributor
Author
|
sorry was away from my laptop for awhile. I think I got everything, have a look. |
winder
previously approved these changes
Nov 9, 2023
algorandskiy
previously approved these changes
Nov 9, 2023
Closed
ohill
approved these changes
Nov 16, 2023
algorandskiy
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds types and utility functions for manipulating nibbles (4-bit value arrays). It is specifically to support a new package, statetrie, which will use Nibbles and their associated utility functions.
The statetrie is designed to have keys with sequences of 4-bit bytes. A statetrie with 16-ary branch nodes has smaller proofs than a full byte (256-ary).