docker: Do not catchup if already initialized.#5756
Merged
winder merged 4 commits intoalgorand:masterfrom Sep 28, 2023
Merged
Conversation
8147317 to
91b5f58
Compare
Codecov Report
@@ Coverage Diff @@
## master #5756 +/- ##
==========================================
- Coverage 55.47% 55.46% -0.02%
==========================================
Files 473 473
Lines 66682 66682
==========================================
- Hits 36995 36984 -11
- Misses 27175 27182 +7
- Partials 2512 2516 +4
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
91b5f58 to
55538e6
Compare
bbroder-uji
reviewed
Sep 27, 2023
Contributor
|
LGTM |
algorandskiy
previously approved these changes
Sep 27, 2023
jannotti
reviewed
Sep 27, 2023
Contributor
jannotti
left a comment
There was a problem hiding this comment.
How do we manage the releases so this doesn't get run against old algods?
Contributor
Author
|
@jannotti the docker image and algod are released and packaged together, so it isn't an issue. |
algorandskiy
previously approved these changes
Sep 28, 2023
jannotti
reviewed
Sep 28, 2023
jannotti
approved these changes
Sep 28, 2023
algorandskiy
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid running fast catchup in docker containers which have already been initialized.
Test Plan
algorand/algod:3.18.0-stable.