goal: Add initialize option to 'goal node catchup'.#5754
Merged
winder merged 9 commits intoalgorand:masterfrom Sep 26, 2023
Merged
goal: Add initialize option to 'goal node catchup'.#5754winder merged 9 commits intoalgorand:masterfrom
winder merged 9 commits intoalgorand:masterfrom
Conversation
jannotti
reviewed
Sep 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #5754 +/- ##
==========================================
- Coverage 55.45% 55.44% -0.01%
==========================================
Files 473 473
Lines 66683 66682 -1
==========================================
- Hits 36979 36972 -7
- Misses 27184 27189 +5
- Partials 2520 2521 +1
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
approved these changes
Sep 26, 2023
algorandskiy
approved these changes
Sep 26, 2023
Contributor
algorandskiy
left a comment
There was a problem hiding this comment.
The code LGTM, the new param name - maybe there are better options.
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new parameter from #5752 to
goal node catchup.Minor refactoring to command to try and simplify the operations. In particular things I didn't like:
args[0]without saying anywhere that it was an optional positional argument.catchupfunction references global abort flag, which is also referenced in the cobra function.Test Plan
Manually tested a bunch of permutations: