config: Add MaxBlockHistoryLookback option#5749
config: Add MaxBlockHistoryLookback option#5749algorandskiy merged 4 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5749 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 476 476
Lines 66857 66859 +2
=======================================
+ Hits 37156 37160 +4
+ Misses 27177 27175 -2
Partials 2524 2524
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
left a comment
There was a problem hiding this comment.
Seems good to me.
Do we ever complain about non-sensical combinations of config? If someone sets this to, say, 3000 but also has Archival set, they are probably confused.
algorandskiy
left a comment
There was a problem hiding this comment.
the code LGTM but please add a unit test and perform a manual test.
algorandskiy
left a comment
There was a problem hiding this comment.
Thank you for the change!
|
Manually tested after catchpoint restore & running a node for a little while with "MaxBlockHistoryLookback": 1500 set: |
Summary
There is no way to request a node to store more blocks if it is not archival. This adds a MaxBlockHistoryLookback similar to MaxAcctLookback config option.
Test Plan
No tests yet