Skip to content

DevOps: fix releases page links#5746

Merged
algorandskiy merged 3 commits intoalgorand:masterfrom
onetechnical:releases-page-link-fix
Sep 21, 2023
Merged

DevOps: fix releases page links#5746
algorandskiy merged 3 commits intoalgorand:masterfrom
onetechnical:releases-page-link-fix

Conversation

@onetechnical
Copy link
Copy Markdown
Contributor

Summary

Links on the releases page are meant to pull from the main repository. However, due to pagination, files were not getting assigned.

This PR fixes this by adding pagination to the file listing from S3. It also syncs signatures for RPMs to the repository.

Test Plan

Ran release page generator and verified it would update links properly.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2023

Codecov Report

Merging #5746 (a5d34b2) into master (3ff5722) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   55.47%   55.46%   -0.02%     
==========================================
  Files         473      473              
  Lines       66675    66675              
==========================================
- Hits        36987    36978       -9     
- Misses      27170    27181      +11     
+ Partials     2518     2516       -2     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algorandskiy
algorandskiy previously approved these changes Sep 19, 2023
Comment thread scripts/release/mule/deploy/releases_page/generate_releases_page.py Outdated
Copy link
Copy Markdown
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok.

@algorandskiy algorandskiy merged commit 2da483b into algorand:master Sep 21, 2023
@onetechnical onetechnical deleted the releases-page-link-fix branch September 22, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants