Merged
Conversation
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
algorandskiy
approved these changes
Sep 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #5745 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 476 476
Lines 66857 66857
=======================================
+ Hits 37156 37157 +1
+ Misses 27177 27175 -2
- Partials 2524 2525 +1 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
approved these changes
Sep 21, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes garbage collection on Windows by removing calls to SetGCPercent and replacing the GC stop with a native buffer allocation (LocalAlloc / LocalFree) for fixedInfoWithOverlay.
The previously used code didn't work well on Windows, causing the GC to stop from collecting. The SetGCPercent(pct) didn't restore the GC.
A minimal program that can be used to reproduce the issue with SetGCPercent on Windows: