p2p: remove TestP2PThreeNodesEvenDist

[iansuvak]

Summary

Currently the TestP2PThreeNodesEvenDist fails pretty regularly. The theory here is that part of the problem is that P2P stream connections take longer to setup than the wsNetwork and that because of that nodes get into a bad state with consensus trying to move too quickly. The errors on the CI runs for these tests indicate that nodes are trying to catchup via gossip protocol but these attempts fail on timeouts.

After further investigation it looks like this behavior is not specific to P2P but happens on the websocket network as well. 50~60% of the time the test takes significantly longer locally but still succeeds. The failure on the CircleCI side is likely just different resourcing leading to slower execution and slower recovery from the bad state that nodes get into. Removing the test for now.

FWIW P2P does pass the PartitionRecovery tests where this network template is used on the websocket network side.

Test Plan

This is a test only change. We want to see whether this change stops the existing test from being so flaky while discussing options to make it more stable and support the faster lambda.

This only removes a flaky test, it should hopefully bring nightly builds back into a stable state.

[codecov]

Codecov Report

Merging #5736 (844588b) into master (527d2c5) will increase coverage by 1.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5736      +/-   ##
==========================================
+ Coverage   54.49%   55.56%   +1.07%     
==========================================
  Files         476      476              
  Lines       66853    66853              
==========================================
+ Hits        36429    37149     +720     
+ Misses      27876    27180     -696     
+ Partials     2548     2524      -24     

see 41 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more