docs: Update node config comments so that they can be used for doc generation.#5729
Merged
winder merged 1 commit intoalgorand:masterfrom Sep 26, 2023
Merged
docs: Update node config comments so that they can be used for doc generation.#5729winder merged 1 commit intoalgorand:masterfrom
winder merged 1 commit intoalgorand:masterfrom
Conversation
winder
commented
Sep 5, 2023
algorandskiy
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #5729 +/- ##
==========================================
+ Coverage 55.54% 55.57% +0.03%
==========================================
Files 476 476
Lines 66853 66853
==========================================
+ Hits 37131 37154 +23
+ Misses 27193 27182 -11
+ Partials 2529 2517 -12
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
approved these changes
Sep 26, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating comments on
config.Localso that they can be used to generate the node configuration page. Here I've mainly chosen the best content from the developer portal and the existing comments.Followup PRs should be made:
Test Plan
Manually ran the config_json_gen and verified that the generated markdown document looks good and has no warnings.