Skip to content

rpcs: simplify API for BlockService to handle multiple HTTP paths#5718

Merged
algorandskiy merged 9 commits intoalgorand:masterfrom
zeldovich:register-http-handler
Jul 26, 2024
Merged

rpcs: simplify API for BlockService to handle multiple HTTP paths#5718
algorandskiy merged 9 commits intoalgorand:masterfrom
zeldovich:register-http-handler

Conversation

@zeldovich
Copy link
Copy Markdown
Contributor

Add a helper BlockService.RegisterHandlers() that registers handlers for multiple HTTP paths, and a RegisterHTTPHandlerFunc() method to GossipNode that can register handler functions in addition to handler objects, in preparation for adding more handlers (specifically, fetching a state proof).

Add a helper BlockService.RegisterHandlers() that registers handlers for
multiple HTTP paths, in preparation for adding more handlers.
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (75bb6a9) to head (cddb78e).
Report is 3 commits behind head on master.

Files Patch % Lines
network/p2p/http.go 0.00% 5 Missing ⚠️
network/hybridNetwork.go 0.00% 3 Missing ⚠️
network/p2pNetwork.go 0.00% 2 Missing ⚠️
network/wsNetwork.go 0.00% 2 Missing ⚠️
rpcs/blockService.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5718      +/-   ##
==========================================
- Coverage   56.29%   56.27%   -0.02%     
==========================================
  Files         488      488              
  Lines       69581    69595      +14     
==========================================
- Hits        39172    39167       -5     
- Misses      27752    27771      +19     
  Partials     2657     2657              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread rpcs/blockService.go Outdated
@algorandskiy algorandskiy requested a review from jasonpaulos July 26, 2024 17:23
@algorandskiy algorandskiy merged commit edda2ee into algorand:master Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants