p2p: Return non-loopback multiaddr from Address() if available#5716
Merged
cce merged 2 commits intoalgorand:masterfrom Sep 1, 2023
Merged
p2p: Return non-loopback multiaddr from Address() if available#5716cce merged 2 commits intoalgorand:masterfrom
cce merged 2 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5716 +/- ##
==========================================
- Coverage 55.51% 55.51% -0.01%
==========================================
Files 473 473
Lines 66316 66320 +4
==========================================
+ Hits 36814 36816 +2
- Misses 27005 27008 +3
+ Partials 2497 2496 -1
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cce
previously approved these changes
Aug 31, 2023
shiqizng
reviewed
Sep 1, 2023
shiqizng
approved these changes
Sep 1, 2023
cce
approved these changes
Sep 1, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When fetching data about the node from the p2p.Service we might end up with a loopback address
/ip4/127.0.0.1/tcp/<port>This works fine for local tests but not for functionality depending on this value spanning multiple nodes.This change fetches the first non-loopback address that's available and if none is available reverts to the old functionality of returning the first one.
Test Plan
Added a new test for the functionality
Also added a mockService struct that we can use from the network if we need to test other functionality