Skip to content

dynamic lambda: current round awareness for AttachReceivedAt, AttachValidatedAt#5715

Closed
cce wants to merge 2 commits intoalgorand:feature/dynamic-lambdafrom
cce:dynamic-lambda-clockround
Closed

dynamic lambda: current round awareness for AttachReceivedAt, AttachValidatedAt#5715
cce wants to merge 2 commits intoalgorand:feature/dynamic-lambdafrom
cce:dynamic-lambda-clockround

Conversation

@cce
Copy link
Copy Markdown
Contributor

@cce cce commented Aug 30, 2023

Summary

This lets AttachReceivedAt and AttachValidatedAt know what the player's current round is, so that they can handle setting timestamps for messages for R+1 better (these are called pipelined votes or proposals). Instead of using the clock for round R they set a timestamp of 1ns for these pipelined messages, since they have arrived before cert quorum was locally observed on R.

Test Plan

Updated existing tests to provide currentRound.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 30, 2023

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.29%. Comparing base (529278a) to head (326561c).

Files with missing lines Patch % Lines
agreement/events.go 81.81% 4 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/dynamic-lambda    #5715      +/-   ##
==========================================================
+ Coverage                   55.26%   55.29%   +0.03%     
==========================================================
  Files                         474      474              
  Lines                       66244    66260      +16     
==========================================================
+ Hits                        36608    36639      +31     
+ Misses                      27172    27156      -16     
- Partials                     2464     2465       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce
Copy link
Copy Markdown
Contributor Author

cce commented Aug 30, 2023

@yossigi adapted and added to the end of #5654, closing

@cce cce closed this Aug 30, 2023
@cce cce deleted the dynamic-lambda-clockround branch August 30, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants