p2p: Close all connections and wsPeers on P2P network shutdown#5712
Merged
cce merged 13 commits intoalgorand:masterfrom Aug 31, 2023
Merged
p2p: Close all connections and wsPeers on P2P network shutdown#5712cce merged 13 commits intoalgorand:masterfrom
cce merged 13 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5712 +/- ##
==========================================
- Coverage 55.21% 55.21% -0.01%
==========================================
Files 473 473
Lines 66156 66180 +24
==========================================
+ Hits 36528 36539 +11
- Misses 27164 27171 +7
- Partials 2464 2470 +6
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iansuvak
commented
Aug 30, 2023
iansuvak
commented
Aug 31, 2023
cce
previously approved these changes
Aug 31, 2023
algorandskiy
approved these changes
Aug 31, 2023
cce
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR defines an innerStop() method similar to the one in wsNetwork that loops through the wsPeers and shuts them down as part of the network Stop method. Additionally it prevents unnecessary logging on node shutdown by checking if the error is caused by context cancellation shutting down the whole node.
Test Plan
Existing tests should pass and data races on wsPeer logging should no-longer occur due to logging after test is over.