p2p: peerstore backed phonebook#5710
Merged
cce merged 16 commits intoalgorand:masterfrom Aug 31, 2023
Merged
Conversation
shiqizng
commented
Aug 24, 2023
shiqizng
requested review from
a team,
Eric-Warehime,
algochoi,
cce,
iansuvak,
tzaffi and
winder
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #5710 +/- ##
==========================================
+ Coverage 55.17% 55.22% +0.04%
==========================================
Files 465 465
Lines 65032 65207 +175
==========================================
+ Hits 35883 36012 +129
- Misses 26764 26793 +29
- Partials 2385 2402 +17
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
reviewed
Aug 24, 2023
Contributor
tzaffi
left a comment
tzaffi
left a comment
There was a problem hiding this comment.
Some questions/suggestions
iansuvak
reviewed
Aug 29, 2023
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
shiqizng
commented
Aug 30, 2023
iansuvak
reviewed
Aug 30, 2023
cce
reviewed
Aug 31, 2023
cce
reviewed
Aug 31, 2023
cce
reviewed
Aug 31, 2023
cce
requested changes
Aug 31, 2023
Contributor
cce
left a comment
cce
left a comment
There was a problem hiding this comment.
Could you remove the duplicate Phonebook interface definition? Otherwise LGTM
Co-authored-by: cce <51567+cce@users.noreply.github.com>
Co-authored-by: cce <51567+cce@users.noreply.github.com>
cce
previously approved these changes
Aug 31, 2023
cce
approved these changes
Aug 31, 2023
Eric-Warehime
approved these changes
Aug 31, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peerstore backed phonebook prototype.