Feature: Disable EnableBlockServiceFallbackToArchiver by default.#5706
Merged
winder merged 4 commits intoalgorand:masterfrom Sep 1, 2023
Merged
Feature: Disable EnableBlockServiceFallbackToArchiver by default.#5706winder merged 4 commits intoalgorand:masterfrom
winder merged 4 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5706 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 474 474
Lines 66615 66615
=======================================
+ Hits 37022 37024 +2
+ Misses 27071 27068 -3
- Partials 2522 2523 +1
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
reviewed
Aug 25, 2023
winder
reviewed
Aug 25, 2023
gmalouf
force-pushed
the
disable-archive-srv-lookup
branch
from
3606679 to
869c142
Compare
onetechnical
previously approved these changes
Aug 30, 2023
algonautshant
previously approved these changes
Aug 30, 2023
Contributor
algonautshant
left a comment
algonautshant
left a comment
There was a problem hiding this comment.
Looks good.
You can also remove this:
catchup/universalFetcher_test.go
97: blockServiceConfig.EnableBlockServiceFallbackToArchiver = false
…fault config of disabling block service archiver fallback in addition to legacy one.
gmalouf
force-pushed
the
disable-archive-srv-lookup
branch
from
869c142 to
52f9121
Compare
gmalouf
dismissed stale reviews from algonautshant and onetechnical
via
cbdb38b
algonautshant
approved these changes
Sep 1, 2023
winder
approved these changes
Sep 1, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given there are no archival server records on mainnet/testnet, repeatedly doing queries for them (and adding warn messages to logs) makes little sense at the moment.
Test Plan
Existing tests pass.