Revert "Ledger: Close the ledger at node shutdown"#5705
Merged
bbroder-algo merged 4 commits intomasterfrom Aug 24, 2023
Merged
Conversation
This reverts commit 8f840c7.
bbroder-algo
approved these changes
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #5705 +/- ##
==========================================
+ Coverage 55.38% 56.02% +0.63%
==========================================
Files 466 470 +4
Lines 65734 65784 +50
==========================================
+ Hits 36407 36855 +448
+ Misses 26877 26454 -423
- Partials 2450 2475 +25
... and 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algobarb
approved these changes
Aug 24, 2023
onetechnical
added a commit
to Algo-devops-service/go-algorand
that referenced
this pull request
Aug 25, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #5668
Tests are occasionally failing, and we theorize that the test succeeds, but the shutdown is timing out. Via Pavel:
"It could the following based on the termination sequence in server.go
node.Stop stops all services first but there could be some active network connections that handled later by server.Shutdown so I suspect some network requests do not allow ledger to be closed or, another way around, server.Shutdown waits longer than 30s after ledger shutdown."
Tests
Ran nightly tests to verify.
https://app.circleci.com/pipelines/github/algorand/go-algorand/16377/workflows/0e0fceb7-111a-492d-9fa0-b0df27285afe