Skip to content

Revert "Ledger: Close the ledger at node shutdown"#5705

Merged
bbroder-algo merged 4 commits intomasterfrom
revert-5668-shant/close_ledger
Aug 24, 2023
Merged

Revert "Ledger: Close the ledger at node shutdown"#5705
bbroder-algo merged 4 commits intomasterfrom
revert-5668-shant/close_ledger

Conversation

@onetechnical
Copy link
Copy Markdown
Contributor

@onetechnical onetechnical commented Aug 23, 2023

Summary

Reverts #5668

Tests are occasionally failing, and we theorize that the test succeeds, but the shutdown is timing out. Via Pavel:

"It could the following based on the termination sequence in server.go

	s.node.Stop()

	err := server.Shutdown(context.Background())

node.Stop stops all services first but there could be some active network connections that handled later by server.Shutdown so I suspect some network requests do not allow ledger to be closed or, another way around, server.Shutdown waits longer than 30s after ledger shutdown."

Tests

Ran nightly tests to verify.

https://app.circleci.com/pipelines/github/algorand/go-algorand/16377/workflows/0e0fceb7-111a-492d-9fa0-b0df27285afe

@onetechnical onetechnical requested a review from a team as a code owner August 23, 2023 19:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 24, 2023

Codecov Report

Merging #5705 (d9bf1f1) into master (51f5314) will increase coverage by 0.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5705      +/-   ##
==========================================
+ Coverage   55.38%   56.02%   +0.63%     
==========================================
  Files         466      470       +4     
  Lines       65734    65784      +50     
==========================================
+ Hits        36407    36855     +448     
+ Misses      26877    26454     -423     
- Partials     2450     2475      +25     
Files Changed Coverage Δ
node/node.go 31.95% <ø> (+27.80%) ⬆️

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbroder-algo bbroder-algo merged commit 9af066b into master Aug 24, 2023
@onetechnical onetechnical deleted the revert-5668-shant/close_ledger branch August 24, 2023 19:25
onetechnical added a commit to Algo-devops-service/go-algorand that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants