cgo: Properly manage memory passing from cgo to go on Batch Verifiers#5700
Merged
algorandskiy merged 13 commits intoalgorand:masterfrom Nov 17, 2023
Merged
cgo: Properly manage memory passing from cgo to go on Batch Verifiers#5700algorandskiy merged 13 commits intoalgorand:masterfrom
algorandskiy merged 13 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5700 +/- ##
==========================================
- Coverage 55.25% 55.24% -0.01%
==========================================
Files 473 473
Lines 66166 66182 +16
==========================================
+ Hits 36558 36565 +7
- Misses 27146 27148 +2
- Partials 2462 2469 +7 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
algorandskiy
previously approved these changes
Aug 30, 2023
jannotti
previously approved these changes
Nov 16, 2023
zeldovich
reviewed
Nov 16, 2023
zeldovich
reviewed
Nov 16, 2023
zeldovich
reviewed
Nov 16, 2023
zeldovich
previously approved these changes
Nov 16, 2023
jannotti
reviewed
Nov 16, 2023
a50dc52
algorandskiy
approved these changes
Nov 17, 2023
jannotti
approved these changes
Nov 17, 2023
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing https://github.com/algorand/go-algorand-internal/issues/3011
From #5695: