Simulate: Enable on follower node & allow specifying starting round#5685
Merged
bbroder-algo merged 10 commits intoalgorand:masterfrom Aug 29, 2023
Merged
Simulate: Enable on follower node & allow specifying starting round#5685bbroder-algo merged 10 commits intoalgorand:masterfrom
bbroder-algo merged 10 commits intoalgorand:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5685 +/- ##
==========================================
+ Coverage 55.06% 55.45% +0.39%
==========================================
Files 473 473
Lines 66281 66316 +35
==========================================
+ Hits 36495 36777 +282
+ Misses 27285 27038 -247
Partials 2501 2501
... and 36 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
previously approved these changes
Aug 25, 2023
ahangsu
reviewed
Aug 25, 2023
Contributor
ahangsu
left a comment
There was a problem hiding this comment.
seems right to me, just asking questions for understandings.
jasonpaulos
commented
Aug 25, 2023
jannotti
previously approved these changes
Aug 25, 2023
ahangsu
previously approved these changes
Aug 28, 2023
ahangsu
approved these changes
Aug 29, 2023
jannotti
approved these changes
Aug 29, 2023
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5651
Additionally, adds simulate option to choose the round the simulation should be based on (instead of always using latest).
Test Plan
Simulatemethods works onAlgorandFollowerNode