-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix close - commit data race in tracker tests #5619
tests: fix close - commit data race in tracker tests #5619
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5619 +/- ##
==========================================
+ Coverage 54.95% 54.98% +0.03%
==========================================
Files 463 463
Lines 64525 64525
==========================================
+ Hits 35457 35480 +23
+ Misses 26684 26664 -20
+ Partials 2384 2381 -3 see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
same data race on nightly |
aa6e9ef
to
56fe81a
Compare
45fe10f
to
2ec26f6
Compare
2ec26f6
to
6b5e1b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just trivial fix suggestion for comments.
What was merged that caused this race? |
#5527 made it much more observable. |
Co-authored-by: Shant Karakashian <[email protected]>
Summary
Fixed data race from this build:
Test Plan
Existing tests