-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: let catchpointdump to calculate and print data hashes #5584
tools: let catchpointdump to calculate and print data hashes #5584
Conversation
97a8514
to
82dd5ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #5584 +/- ##
==========================================
- Coverage 55.79% 55.77% -0.02%
==========================================
Files 446 446
Lines 63418 63428 +10
==========================================
- Hits 35381 35374 -7
- Misses 25668 25687 +19
+ Partials 2369 2367 -2
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only //comment suggestions
@@ -76,6 +77,11 @@ func (m *catchpointCatchupAccessorMock) Ledger() (l ledger.CatchupAccessorClient | |||
return m.l | |||
} | |||
|
|||
// GetVerifyData returns the balances hash, spver hash and totals used by VerifyCatchpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment appears copy/paste from the real impl, may want to just mention that this is a stub to satisfy the interface.
@@ -67,6 +69,11 @@ func (m *MockCatchpointCatchupAccessor) GetCatchupBlockRound(ctx context.Context | |||
return basics.Round(0), nil | |||
} | |||
|
|||
// GetVerifyData returns the balances hash, spver hash and totals used by VerifyCatchpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment appears copy/paste from the real impl, may want to just mention that this is a stub to satisfy the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Summary
Test Plan
Tested manually