-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: adding peerstore #5576
p2p: adding peerstore #5576
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5576 +/- ##
==========================================
+ Coverage 55.79% 55.84% +0.05%
==========================================
Files 446 448 +2
Lines 63418 63451 +33
==========================================
+ Hits 35381 35437 +56
+ Misses 25668 25651 -17
+ Partials 2369 2363 -6
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very promising and clean!
I made some suggestions regarding adding test cases and wrapping errors from external libraries with our own messages to improve debuggability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous questions have been addressed and new questions don't block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this now. We can adjust any things which end up needing changes in any future PRs as necessary.
This PR adds a peerstore module.
Info
Closes #5544