test: Replace timer with counter loop in TestNodeTxHandlerRestart

[algonautshant]

Enhance the wait for catchpoint by looping instead of the timer to avoid timer runout without looping under stressed environments.

[Eric-Warehime]

Should probably update all the other tests running similar loops:

• https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L667
• https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L719
• https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L827
• https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L55

[codecov]

Codecov Report

Merging #5533 (9b18258) into master (3e80027) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5533      +/-   ##
==========================================
+ Coverage   55.78%   55.86%   +0.07%     
==========================================
  Files         446      446              
  Lines       63262    63262              
==========================================
+ Hits        35293    35343      +50     
+ Misses      25590    25553      -37     
+ Partials     2379     2366      -13     

see 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[algorandskiy]

Could you also log how many iterations it took?

[algonautshant]

Could you also log how many iterations it took?

When if fails, it is the full 1000 iterations, so no need to report.
When in passes, we don't log/report anything. Do you want to?

[algorandskiy]

Yes, I'd like to see if have it logged if it was stuck in the loop for more than 10 sec (40 iterations looks like).

[ASISBusiness]

Working

[winder]

If this is more about time than the number of attempts, require.Eventually can manage the loop / duration automatically:
https://github.com/stretchr/testify/blob/v1.8.4/assert/assertions.go#L1833