-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Replace timer with counter loop in TestNodeTxHandlerRestart #5533
test: Replace timer with counter loop in TestNodeTxHandlerRestart #5533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably update all the other tests running similar loops:
- https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L667
- https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L719
- https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L827
- https://github.com/algorand/go-algorand/blob/master/test/e2e-go/features/catchup/catchpointCatchup_test.go#L55
Codecov Report
@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
+ Coverage 55.78% 55.86% +0.07%
==========================================
Files 446 446
Lines 63262 63262
==========================================
+ Hits 35293 35343 +50
+ Misses 25590 25553 -37
+ Partials 2379 2366 -13 see 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also log how many iterations it took?
When if fails, it is the full 1000 iterations, so no need to report. |
Yes, I'd like to see if have it logged if it was stuck in the loop for more than 10 sec (40 iterations looks like). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working
If this is more about time than the number of attempts, |
Enhance the wait for catchpoint by looping instead of the timer to avoid timer runout without looping under stressed environments.