-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: proper cross product check for app put and del #5467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly reasonable move, just up jason's find.
Codecov Report
@@ Coverage Diff @@
## master #5467 +/- ##
==========================================
- Coverage 55.63% 49.80% -5.84%
==========================================
Files 447 447
Lines 63405 63409 +4
==========================================
- Hits 35274 31578 -3696
- Misses 25751 29408 +3657
- Partials 2380 2423 +43
... and 184 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is repairing an oversight in group resource sharing which incorrectly made available to an application its own app local data for a different sender address (used in a different transaction in the group). While that different sender address is "available" under the new resource sharing rules, it should not imply that local data for all applications are available to read/write in that address. To enable read/write, the other address must be available in the foreign array of the same top-level transaction as the app call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one minor thing, but I think it should be good.
1f4862b
to
573d0e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test: construct app that tries to modify a local state for which it only has access to the account, not the local state