build: remove boost dependency and internal sortition package #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
force-pushed
the
remove-internal-sortition
branch
from
da5a783
to
de2a5a3
Compare
cce
force-pushed
the
remove-internal-sortition
branch
from
de2a5a3
to
ec287ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #5459 +/- ##
==========================================
- Coverage 55.56% 55.52% -0.05%
==========================================
Files 448 447 -1
Lines 63375 63356 -19
==========================================
- Hits 35216 35176 -40
- Misses 25786 25800 +14
- Partials 2373 2380 +7 see 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gmalouf
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that #5429 has merged and we are using an external sortition package with fixed C++ dependencies, we can remove the OS dependency on boost and the data/committee/sortition package that requires it.
Test Plan
Existing tests and build jobs should pass.