algod: Move delta API tags #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5396 +/- ##
=======================================
Coverage 55.39% 55.40%
=======================================
Files 452 452
Lines 63685 63685
=======================================
+ Hits 35281 35285 +4
- Misses 25980 25982 +2
+ Partials 2424 2418 -6 see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algochoi
approved these changes
May 17, 2023
algorandskiy
approved these changes
May 17, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to generate code for the SDKs we need these to be non-experimental APIs. We also want them to be enabled independent of users having to turn on follow mode.
Move the delta APIs to be default enabled on algod. This won't affect any production code paths--the EvalTracer for txn group deltas still needs to be turned on via a separate config option.
Test Plan
No functional changes--existing tests cover.