-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: EvalDelta and ConsensusParams x-repo type checks #5381
Merged
algorandskiy
merged 42 commits into
algorand:master
from
tzaffi:23may-indexer-import-types
Jun 5, 2023
Merged
tools: EvalDelta and ConsensusParams x-repo type checks #5381
algorandskiy
merged 42 commits into
algorand:master
from
tzaffi:23may-indexer-import-types
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5381 +/- ##
==========================================
- Coverage 55.44% 50.13% -5.32%
==========================================
Files 447 447
Lines 63272 79614 +16342
==========================================
+ Hits 35083 39916 +4833
- Misses 25810 37321 +11511
+ Partials 2379 2377 -2 see 418 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
commented
May 12, 2023
This was referenced May 12, 2023
tzaffi
commented
May 19, 2023
winder
previously approved these changes
May 26, 2023
tzaffi
commented
May 26, 2023
EvalDelta
& ConsensusParams
x-repo type checks + bugfix: start testing subdirectories with a go.mod
EvalDelta
& ConsensusParams
x-repo type checks + bugfix: start testing subdirectories with a go.mod
EvalDelta
& ConsensusParams
x-repo type checks + bugfix: start testing subdirectories with a go.mod
tzaffi
commented
Jun 2, 2023
tzaffi
commented
Jun 2, 2023
tzaffi
commented
Jun 2, 2023
cce
reviewed
Jun 2, 2023
EvalDelta
& ConsensusParams
x-repo type checksEvalDelta
& ConsensusParams
x-repo type checks
algorandskiy
reviewed
Jun 5, 2023
tzaffi
commented
Jun 5, 2023
cce
approved these changes
Jun 5, 2023
EvalDelta
& ConsensusParams
x-repo type checks
algorandskiy
approved these changes
Jun 5, 2023
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1. Introduce recursive
go test ./...
in CI andgo mod tidy
both inMakefile
andCI
It turns out that the x-repo-types tests weren't actually running in C.I. This is because
go test ./...
(andgotestsum
) don't recurse into module directories (those that have ago.mod
file).We can see that this commit very happily passed CI:
![image](https://private-user-images.githubusercontent.com/291133/241338947-2dac468b-9865-4588-930e-2694a30d686e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3MTUyMDAsIm5iZiI6MTcyNDcxNDkwMCwicGF0aCI6Ii8yOTExMzMvMjQxMzM4OTQ3LTJkYWM0NjhiLTk4NjUtNDU4OC05MzBlLTI2OTRhMzBkNjg2ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyNlQyMzI4MjBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMjRiNTI4Y2JjZWM1OGQwNTZhZjFmY2IyODViNWE5YzYyNTFjNzMzZjYzZTNkMTUzZjM4MDBlZTU1OTA5OThjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.1Sysr8WthFTCnasUskArwQkEUaPN_J_vVtO27rbWoPU)
References
Summary of CI/Makefile Changes:
.github/workflows/tools.yml
- (thanks @cce cf. GHA for tools tzaffi/go-algorand#17)Makefile
- Recursive recipe formake tidy
2. Introduce more cross-type checks
EvalDelta
indata.transactions
vs. ingo-algorand-sdk
'stypes
.ConsensusParams
inconfig
vs. ingo-algorand-sdk
'sprotocol.config
Context
EvalDelta
was introduced to fix failing Indexer end-to-end tests. See:ConsensusParams
was moved from indexer to go-algorand-sdk in algorand/go-algorand-sdk#543Related Issues
ConsensusAccountData
fromAccountData
#5316F.A.Q.
Which tests were being skipped and what is the impact going forward?
cmd/partitiontest_linter/linter_test.go- STILL SKIPPED GOING FORWARDTesting
Purely on CI