tools: EvalDelta and ConsensusParams x-repo type checks

[tzaffi]

Summary

1. Introduce recursive go test ./... in CI and go mod tidy both in Makefile and CI

It turns out that the x-repo-types tests weren't actually running in C.I. This is because go test ./... (and gotestsum) don't recurse into module directories (those that have a go.mod file).

We can see that this commit very happily passed CI:

References

• StackOverflow
• gotestsum

Summary of CI/Makefile Changes:

• Introducing .github/workflows/tools.yml - (thanks @cce cf. GHA for tools tzaffi/go-algorand#17)
• Makefile - Recursive recipe for make tidy

2. Introduce more cross-type checks

• EvalDelta in data.transactions vs. in go-algorand-sdk's types.
• ConsensusParams in config vs. in go-algorand-sdk's protocol.config

Context

EvalDelta was introduced to fix failing Indexer end-to-end tests. See:

• E2E-Tests are failing CI indexer#1521
• bugfix: adding EvalDelta.SharedAccts go-algorand-sdk#531
• bugfix: indexer import types conduit#73

ConsensusParams was moved from indexer to go-algorand-sdk in algorand/go-algorand-sdk#543

Related Issues

• Split ConsensusAccountData from AccountData #5316
• enhancement: run tests for non-root sub-directory go modules #5427

F.A.Q.

Which tests were being skipped and what is the impact going forward?

• cmd/partitiontest_linter/linter_test.go - STILL SKIPPED GOING FORWARD
• tools/block-generator/generator/generate_test.go
• tools/block-generator/generator/server_test.go
• tools/block-generator/generator/utils_test.go
• tools/x-repo-types/typeAnalyzer/typeAnalyzer_test.go
• tools/x-repo-types/xrt_test.go

Testing

Purely on CI

[codecov]

Codecov Report

Merging #5381 (65351c4) into master (5faa4d0) will decrease coverage by 5.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5381      +/-   ##
==========================================
- Coverage   55.44%   50.13%   -5.32%     
==========================================
  Files         447      447              
  Lines       63272    79614   +16342     
==========================================
+ Hits        35083    39916    +4833     
- Misses      25810    37321   +11511     
+ Partials     2379     2377       -2     

see 418 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more