-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: option to override topology file and peer address. #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5209 +/- ##
==========================================
- Coverage 53.57% 44.66% -8.91%
==========================================
Files 441 441
Lines 55094 55094
==========================================
- Hits 29515 24608 -4907
- Misses 23300 28148 +4848
- Partials 2279 2338 +59 see 196 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
reviewed
Mar 15, 2023
winder
reviewed
Mar 15, 2023
winder
reviewed
Mar 16, 2023
winder
previously approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
excalq
reviewed
Mar 28, 2023
excalq
previously approved these changes
Mar 28, 2023
winder
approved these changes
Mar 28, 2023
excalq
approved these changes
Mar 28, 2023
winder
changed the title
docker container: dockerfile update
docker: option to override topology file and peer address.
Mar 29, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating dockerfile to support devmode + followermode container
PEER_ADDRESS
for running multiple containers. A follower node container can connect to the relay node container by setting the host:port inPEER_ADDRESS
.