algocfg: Bug fix - Add colon to indicate port specification#5193
Merged
onetechnical merged 1 commit intoMar 10, 2023
Conversation
winder
approved these changes
Mar 10, 2023
cce
approved these changes
Mar 10, 2023
algobarb
approved these changes
Mar 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #5193 +/- ##
==========================================
- Coverage 53.51% 50.67% -2.85%
==========================================
Files 439 439
Lines 55012 55012
==========================================
- Hits 29442 27875 -1567
- Misses 23283 24805 +1522
- Partials 2287 2332 +45
... and 88 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new profile uses
4160for theNetAddressfield, but this needs to specify a port. Changed this to:4160.It'll fail to start catchup with the relay profile when set as is.
Test Plan
Set config profile to relay and started a node, verified that it was catching up.