ERL: Support zero-size reservations#5192
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5192 +/- ##
==========================================
- Coverage 53.51% 53.51% -0.01%
==========================================
Files 439 439
Lines 55012 55014 +2
==========================================
- Hits 29442 29440 -2
- Misses 23283 23288 +5
+ Partials 2287 2286 -1
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icorderi
approved these changes
Mar 13, 2023
algorandskiy
changed the title
algorandskiy
approved these changes
Mar 13, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ERL when
CapacityPerReservationset to 0.Test Plan
Added a unit test