StateProofRecoverabiliy: CR fixes#5176
Merged
algorandskiy merged 9 commits intoalgorand:feature/stateproofs-recoverabilityfrom Mar 13, 2023
Merged
StateProofRecoverabiliy: CR fixes#5176algorandskiy merged 9 commits intoalgorand:feature/stateproofs-recoverabilityfrom
algorandskiy merged 9 commits intoalgorand:feature/stateproofs-recoverabilityfrom
Conversation
id-ms
changed the title
Codecov Report
@@ Coverage Diff @@
## feature/stateproofs-recoverability #5176 +/- ##
======================================================================
- Coverage 54.43% 53.73% -0.71%
======================================================================
Files 445 441 -4
Lines 55533 55489 -44
======================================================================
- Hits 30230 29817 -413
- Misses 22936 23333 +397
+ Partials 2367 2339 -28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
id-ms
force-pushed
the
spr-cr-fix
branch
2 times, most recently
from
f906a20 to
165a239
Compare
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
LGTM, one comment request
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func TestCatchpointFileWithLargeSpVerification(t *testing.T) { |
Contributor
There was a problem hiding this comment.
please add a brief comment for this test
added 2 commits
March 13, 2023 18:10
id-ms
changed the title
algorandskiy
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan